Skip to content

[Bootstrap] Simplify codepoints parsing#910

Merged
egorikftp merged 1 commit into
mainfrom
task/simplify-code-points-parsing
Feb 27, 2026
Merged

[Bootstrap] Simplify codepoints parsing#910
egorikftp merged 1 commit into
mainfrom
task/simplify-code-points-parsing

Conversation

@egorikftp

@egorikftp egorikftp commented Feb 27, 2026

Copy link
Copy Markdown
Member

📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@egorikftp egorikftp requested a review from t-regbs February 27, 2026 15:03
@coderabbitai

coderabbitai Bot commented Feb 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b8a4e6 and 025b4bc.

📒 Files selected for processing (2)
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/bootstrap/data/BootstrapRepository.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/bootstrap/domain/BootstrapUseCase.kt

Walkthrough

The changes refactor the Bootstrap icon data loading in the Valkyrie IDE plugin. The public loadIconList() function was removed from BootstrapRepository. A call to this function in BootstrapUseCase's loadConfig() method was replaced with a direct call to loadCodepoints(). The custom parseCodepoints helper function was deleted and replaced with direct usage of json.decodeFromString<Map<String, Int>>(jsonText) for JSON parsing. Unused imports were removed.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description contains only the changelog template with checkboxes but lacks substantive information about the changes, rationale, or implementation details beyond the title. Add a brief explanation of why this simplification was made and what problem it solves, beyond just the changelog checklist.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: simplifying codepoints parsing in the Bootstrap module by removing the loadIconList() method and using loadCodepoints() directly.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch task/simplify-code-points-parsing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

t-regbs
t-regbs approved these changes Feb 27, 2026
View reviewed changes

@t-regbs t-regbs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@egorikftp egorikftp merged commit 9e7b773 into main Feb 27, 2026
4 checks passed
@egorikftp egorikftp deleted the task/simplify-code-points-parsing branch February 27, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-regbs t-regbs t-regbs approved these changes

Assignees

No one assigned

Labels

housekeeping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@egorikftp @t-regbs