Skip to content

[Web Import] Fix state restoration when hiding and reopening the plugin#909

Merged
egorikftp merged 1 commit into
mainfrom
bug/saved-stata
Feb 27, 2026
Merged

[Web Import] Fix state restoration when hiding and reopening the plugin#909
egorikftp merged 1 commit into
mainfrom
bug/saved-stata

Conversation

@egorikftp

@egorikftp egorikftp commented Feb 27, 2026

Copy link
Copy Markdown
Member

📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@egorikftp egorikftp requested a review from t-regbs February 27, 2026 15:01
@coderabbitai

coderabbitai Bot commented Feb 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b8a4e6 and 45f9b58.

📒 Files selected for processing (2)
  • tools/idea-plugin/CHANGELOG.md
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/StandardIconViewModel.kt

Walkthrough

This pull request updates the CHANGELOG to document a fix for web import state restoration when hiding and reopening the plugin. Additionally, the initialization logic in StandardIconViewModel is refactored from a guarded when expression to a nested-if structure. The refactoring maintains identical functionality: when StandardState.Success is received with a null fontByteArray, downloadFont() is called; otherwise loadConfig() is executed. The behavioral logic and control flow remain unchanged.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description only contains the changelog template checkbox structure without any substantive explanation of the change, its rationale, or implementation details. Add a detailed description explaining what the bug was, why it occurred, and how the fix resolves it before merging.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: fixing state restoration for the Web Import feature when hiding/reopening the plugin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bug/saved-stata

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@egorikftp egorikftp merged commit b066299 into main Feb 27, 2026
4 checks passed
@egorikftp egorikftp deleted the bug/saved-stata branch February 27, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-regbs t-regbs t-regbs approved these changes

Assignees

No one assigned

Labels

bugfix-intellij-plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@egorikftp @t-regbs