tools/gradle-plugin/src/main/kotlin/io/github/composegears/valkyrie/gradle/internal/task/GenerateImageVectorsTask.kt (1)

91-91: usePathDataString is hardcoded to false — consider exposing it as a configurable Gradle plugin option.

Unlike other generation options (useExplicitMode, addTrailingComma, etc.) which are backed by @Input properties, usePathDataString is hardcoded. This means Gradle plugin users cannot opt into path data string generation. If this is intentional for the initial rollout (IDE-only), a // TODO comment would help track the gap.

sdk/intellij/psi/imagevector/src/main/kotlin/io/github/composegears/valkyrie/sdk/intellij/psi/imagevector/common/KtCallExpression.kt (1)

78-87: Silent empty-list fallback on parse failure — consider whether this is acceptable.

When PathParser.parsePathString throws (Line 86), runCatching silently returns an empty path list. This means a malformed pathData string in the source file will produce an icon with no visible paths, with no indication of the parse error. The same silent-failure pattern applies to the early-return guards.

This is consistent with the other extract*/parse* functions in this file that return defaults on missing/invalid input, so it may be intentional. Just flagging in case logging the error or propagating it would be preferred for debuggability.

sdk/intellij/psi/imagevector/src/main/kotlin/io/github/composegears/valkyrie/sdk/intellij/psi/imagevector/parser/RegularImageVectorPsiParser.kt (2)

71-83: Consider using when or else if to avoid redundant checks.

The sequential if statements mean all three conditions are evaluated even after a match. A when expression would be more idiomatic and slightly more efficient, though this follows the existing pattern in the file.

♻️ Suggested refactor

     private fun KtCallExpression.parseVectorNode(): IrVectorNode? {
-        var node: IrVectorNode? = null
-        if (calleeExpression?.text == "path") {
-            node = parsePath()
-        }
-        if (calleeExpression?.text == "addPath") {
-            node = parseAddPath()
-        }
-        if (calleeExpression?.text == "group") {
-            node = parseGroup()
-        }
-        return node
+        return when (calleeExpression?.text) {
+            "path" -> parsePath()
+            "addPath" -> parseAddPath()
+            "group" -> parseGroup()
+            else -> null
+        }
     }

---

126-140: parseAddPath largely duplicates parsePath — consider extracting shared parameter parsing.

Both parseAddPath (lines 126–140) and parsePath (lines 107–124) construct IrVectorNode.IrPath with identical field extraction logic for all parameters except paths. A shared helper could reduce duplication, but this is manageable given the scope.