Skip to content

Migrate to Junit5 + AssertK#64

Merged
egorikftp merged 2 commits into
ComposeGears:mainfrom
Goooler:migrate-to-assert-k
Jul 28, 2024
Merged

Migrate to Junit5 + AssertK#64
egorikftp merged 2 commits into
ComposeGears:mainfrom
Goooler:migrate-to-assert-k

Conversation

@Goooler

@Goooler Goooler commented Jul 28, 2024

Copy link
Copy Markdown
Member

@Goooler Goooler force-pushed the migrate-to-assert-k branch from 8085c18 to f2d1e78 Compare July 28, 2024 03:47
@Goooler

Goooler commented Jul 28, 2024

Copy link
Copy Markdown
Member Author

May merge #65 first.

@egorikftp egorikftp force-pushed the migrate-to-assert-k branch from f2d1e78 to 2b98b98 Compare July 28, 2024 09:39
@egorikftp

Copy link
Copy Markdown
Member

Can be AssertK due to now we don't test any coroutines logic)

@Goooler

Goooler commented Jul 28, 2024

Copy link
Copy Markdown
Member Author

You want https://github.com/cashapp/turbine.

@Goooler

Goooler commented Jul 28, 2024

Copy link
Copy Markdown
Member Author

Verified, tests are reported at https://scans.gradle.com/s/yz46z7wp4eyzy/tests/overview.

One more thing, I need to fix https://scans.gradle.com/s/yz46z7wp4eyzy/deprecations

@egorikftp

Copy link
Copy Markdown
Member

turbine can be added if necessary in future 🙂

@Goooler Goooler force-pushed the migrate-to-assert-k branch from 2b98b98 to 74fa636 Compare July 28, 2024 09:49
Comment thread gradle/libs.versions.toml
xpp3 = "org.ogce:xpp3:1.1.6"

junit5-jupiter = "org.junit.jupiter:junit-jupiter:5.10.3"
junit-launcher = { module = "org.junit.platform:junit-platform-launcher" }

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@egorikftp egorikftp merged commit e78a4a6 into ComposeGears:main Jul 28, 2024
@Goooler Goooler deleted the migrate-to-assert-k branch July 28, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants