Skip to content

Fix task dependencies in Gradle plugin#1014

Merged
egorikftp merged 1 commit into
mainfrom
bug/gradle/codegen-fix
Jun 3, 2026
Merged

Fix task dependencies in Gradle plugin#1014
egorikftp merged 1 commit into
mainfrom
bug/gradle/codegen-fix

Conversation

@egorikftp

@egorikftp egorikftp commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@coderabbitai

coderabbitai Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3458f6af-cb3a-4c06-916f-13cc3c0b0c01

📥 Commits

Reviewing files that changed from the base of the PR and between 25a7156 and 7a34657.

📒 Files selected for processing (3)
  • gradle/gradle.versions.toml
  • tools/gradle-plugin/CHANGELOG.md
  • tools/gradle-plugin/src/main/kotlin/io/github/composegears/valkyrie/gradle/ValkyrieGradlePlugin.kt

Walkthrough

This PR bumps the Gradle plugin to 0.5.1, adds a changelog entry for 0.5.1, and refactors task dependency wiring to use KotlinCompilationTask<>. The plugin now makes extractAnnotations*, sourcesJar/SourcesJar, and all KotlinCompilationTask<> instances explicitly depend on the image-vector codegen tasks; imports, comments, and Javadoc were updated to reflect KotlinCompilationTask.dependsOn usage.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: fixing task dependencies in the Gradle plugin, which aligns with the core modifications across all three changed files.
Description check ✅ Passed The PR description includes the changelog template with the Gradle Plugin changelog properly marked as updated, which is accurate given the CHANGELOG.md modifications.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug/gradle/codegen-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@egorikftp

egorikftp commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@egorikftp egorikftp merged commit f6e3283 into main Jun 3, 2026
5 checks passed
@egorikftp egorikftp deleted the bug/gradle/codegen-fix branch June 3, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix-gradle-plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@egorikftp