Skip to content

Replace rememberPluginVersion with ValkyrieBuildConfig due Internal API usage#1008

Merged
egorikftp merged 1 commit into
mainfrom
task/idea-intenal-api
May 29, 2026
Merged

Replace rememberPluginVersion with ValkyrieBuildConfig due Internal API usage#1008
egorikftp merged 1 commit into
mainfrom
task/idea-intenal-api

Conversation

@egorikftp

@egorikftp egorikftp commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

PluginManagerCore.getPlugin() marked as Internal API in IntelliJ IDEA 2026.2 EAP

Issue: https://platform.jetbrains.com/t/pluginmanagercore-getplugin-is-now-internal/4272

📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 574ff9a6-6e21-401d-af89-e7b9e9420e3b

📥 Commits

Reviewing files that changed from the base of the PR and between 3dbb5a4 and 15010cc.

📒 Files selected for processing (4)
  • tools/idea-plugin/build.gradle.kts
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/intro/IntroScreen.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/intro/util/PluginVersion.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/about/AboutSettingsScreen.kt
💤 Files with no reviewable changes (1)
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/intro/util/PluginVersion.kt

Walkthrough

The pull request refactors how the Valkyrie IntelliJ plugin displays its version. A buildconfig Gradle plugin was added to tools/idea-plugin/build.gradle.kts to generate a ValkyrieBuildConfig class containing a VERSION constant sourced from the IntelliJ plugin version provider. The version display logic in IntroScreen and AboutSettingsScreen was updated to reference this build-time constant instead of calling the rememberPluginVersion() composable, which was then removed. Import statements were updated accordingly across the UI screens.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: replacing rememberPluginVersion with ValkyrieBuildConfig to address Internal API usage concerns.
Description check ✅ Passed The description provides context about the Internal API issue and includes the changelog checklist template, with the IntelliJ Plugin checkbox marked as complete.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task/idea-intenal-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@egorikftp egorikftp merged commit a3279fd into main May 29, 2026
7 checks passed
@egorikftp egorikftp deleted the task/idea-intenal-api branch May 29, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature-intellij-plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@egorikftp