Add settings for ImageVector gutter icon visibility and prompt for IDE restart#1006
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (4)
Hidden review stack artifactWalkthroughThis PR adds a new persistent setting to control the visibility of ImageVector gutter icons in the Valkyrie IntelliJ plugin. The setting is defined in the persistent state layer, propagated through in-memory settings, exposed in the settings UI with a restart confirmation dialog, and consumed by the gutter provider to conditionally skip marker collection. Localized UI strings for the new setting and restart dialog are included, and the changelog is updated to document the feature. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/ImageVectorPreviewSettingsScreen.kt`:
- Around line 74-80: The CheckboxSettingsRow for the gutter icon toggle is
calling promptRestart when toggled; remove that prompt so toggling
UpdateImageVectorGutterIcon no longer triggers an IDE restart prompt —
ImageVectorGutterProvider.collectSlowLineMarkers already reads
persistentSettings.state.showImageVectorGutterIcon so the change is picked up at
runtime. Locate the CheckboxSettingsRow (text from
"settings.imagevector.preview.ide.option.guttericon") and in its onCheckedChange
handler keep the onAction(UpdateImageVectorGutterIcon(it)) call but eliminate
the promptRestart(component) invocation (or guard it behind a different
condition if other cases still require restart).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 709088aa-d43d-4ed1-9f3a-34d80768cad7
📒 Files selected for processing (8)
tools/idea-plugin/CHANGELOG.mdtools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/gutter/ImageVectorGutterProvider.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/service/PersistentSettings.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/settings/InMemorySettings.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/SettingsViewModel.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/model/SettingsAction.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/ImageVectorPreviewSettingsScreen.kttools/idea-plugin/src/main/resources/messages/Valkyrie.properties
c654ac8 to
44596c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-05-29.at.09.23.42.mov
📝 Changelog
If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs: