Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Aug 22, 2023

Exchange of pica to osmo happens on Osmosis, and it sends message transfer back.
Tuned devnet relayer for more stability.
Added shells and tuned scripts to work with test and prod nets.

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 26 8h 11m 12
blasrodri 20 1h 58m 6
mina86 19 14h 8m 74
kkast 11 3h 17m 7
RustNinja 11 1h 31m 2
vmarkushin 5 7h 2
JafarAz 3 9h 25m 0
0xBrainjar2 2 3d 17h 35m 6

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4097/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4097/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4097/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4097/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4097/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda dzmitry-lahoda requested a review from fl-y August 22, 2023 18:05
@dzmitry-lahoda dzmitry-lahoda changed the title feat(xcvm): swap on devnet demo #check feat(xcvm): swap on devnet demo Aug 22, 2023
@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review August 22, 2023 18:06
auto-merge was automatically disabled August 24, 2023 10:09

Merge queue setting changed

@dzmitry-lahoda dzmitry-lahoda changed the title feat(xcvm): swap on devnet demo feat(xcvm): swap on devnet demo, and testnet and prod deployments scripts Aug 25, 2023
@dzmitry-lahoda dzmitry-lahoda enabled auto-merge (squash) August 25, 2023 17:47
@dzmitry-lahoda
Copy link
Contributor Author

merging as needed to do release as release link needed to create gov proposal, also no code changes done are in production code and all parties were notified week ago about review need. please raise any issue as needed and i will fix it in next pr.

@dzmitry-lahoda dzmitry-lahoda merged commit 05d38e0 into main Aug 28, 2023
@dzmitry-lahoda dzmitry-lahoda deleted the dz/4 branch August 28, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants