Skip to content

Conversation

@blasrodri
Copy link
Contributor

a better strategy than this hard-coded naive one.

We are then removing this one.

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

a better strategy than this hard-coded naive one.

We are then removing this one.
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 28 8h 51m 18
blasrodri 19 2h 33m 6
mina86 17 12h 56m 64
RustNinja 15 1h 17m 2
kkast 11 3h 17m 7
vmarkushin 3 7h 2
JafarAz 3 9h 25m 0
0xBrainjar2 2 3d 17h 35m 6

@blasrodri blasrodri self-assigned this Aug 17, 2023
@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4080/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4080/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4080/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4080/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4080/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@blasrodri blasrodri marked this pull request as ready for review August 17, 2023 16:22
@blasrodri blasrodri changed the title ibc: Rate limit has been enforced on Centauri using feat: (IBC) Rate limit has been enforced on Centauri using Aug 17, 2023
@blasrodri blasrodri added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit 97c87e6 Aug 17, 2023
@blasrodri blasrodri deleted the remove-rate-limit branch August 17, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants