Skip to content

Conversation

@RustNinja
Copy link
Contributor

@RustNinja RustNinja commented Aug 10, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 23 8h 22m 23
RustNinja 19 1h 31m 2
blasrodri 16 1h 23m 10
mina86 12 1d 40m 78
kkast 12 3h 26m 6
vmarkushin 2 1h 8m 0
0xBrainjar2 1 3d 17h 35m 6
JafarAz 1 9h 25m 0

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4049/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4049/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4049/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4049/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4049/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@RustNinja RustNinja requested review from blasrodri, dzmitry-lahoda, kkast and vmarkushin and removed request for kkast August 10, 2023 13:01
@kkast
Copy link
Contributor

kkast commented Aug 10, 2023

test locally

Copy link
Contributor

@kkast kkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for local testing

@RustNinja RustNinja requested a review from kkast August 10, 2023 18:53
@RustNinja RustNinja requested a review from kkast August 11, 2023 13:30
@dzmitry-lahoda
Copy link
Contributor

@RustNinja may you elaborate on on how check was concluded that regression did not happen?
If if was not tested, what is step by step guide to do so?

image

@RustNinja
Copy link
Contributor Author

@RustNinja may you elaborate on on how check was concluded that regression did not happen? If if was not tested, what is step by step guide to do so?

image

We did the regression of new functionality and this changes should go to production.
so I will remove this checks from pr.

Copy link
Contributor

@kkast kkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@kkast kkast enabled auto-merge August 11, 2023 18:28
@kkast kkast added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit c988957 Aug 11, 2023
@kkast kkast deleted the fix-timeout-memo-type branch August 11, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants