Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Aug 3, 2023

image

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists https://github.com/ComposableFi/research/issues/244
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
RustNinja 20 4h 41m 2
dzmitry-lahoda 18 22h 8m 27
blasrodri 10 18h 45m 11
mina86 7 1d 13h 32m 54
kkast 5 1d 23h 2m 4
vmarkushin 1 12d 19h 41m 3
josietyleung 1 1d 20h 28m 3

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4012/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4012/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4012/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4012/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 

About nix

@dzmitry-lahoda dzmitry-lahoda added the WIP Work in Progress, #WIP #owned:terraform label Aug 3, 2023
@dzmitry-lahoda dzmitry-lahoda marked this pull request as draft August 3, 2023 15:47
@dzmitry-lahoda dzmitry-lahoda changed the title feat(xcvm): assets handling - docs, events, devnet setup #wip #draft feat(xcvm): assets handling - docs, events, devnet setup Aug 3, 2023
@dzmitry-lahoda dzmitry-lahoda added Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform and removed WIP Work in Progress, #WIP #owned:terraform labels Aug 3, 2023
@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review August 3, 2023 17:02
dzmitry-lahoda and others added 4 commits August 3, 2023 18:23
Co-authored-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>
Co-authored-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>
@dzmitry-lahoda dzmitry-lahoda requested a review from mina86 August 3, 2023 17:28
mina86
mina86 previously approved these changes Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants