Skip to content

RHEL: increase /boot partition size in kickstarts#14351

Merged
Mab879 merged 4 commits intoComplianceAsCode:masterfrom
vojtapolasek:increase_boot_part_size_in_ks
Feb 10, 2026
Merged

RHEL: increase /boot partition size in kickstarts#14351
Mab879 merged 4 commits intoComplianceAsCode:masterfrom
vojtapolasek:increase_boot_part_size_in_ks

Conversation

@vojtapolasek
Copy link
Collaborator

@vojtapolasek vojtapolasek commented Feb 2, 2026 •
edited
Loading

Description:

  • in each kickstart where /boot is defined, increase its size to 2048 from 512
  • add reqpart to all kickstarts where autopart is not used
  • align mount options set in kickstarts with rules in profiles

Rationale:

Review Hints:

Build the content and inspect changes in kickstart.

@vojtapolasek vojtapolasek added this to the 0.1.80 milestone Feb 2, 2026
@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. RHEL9 Red Hat Enterprise Linux 9 product related. RHEL8 Red Hat Enterprise Linux 8 product related. Kickstart Kickstart file updates. labels Feb 2, 2026
@vojtapolasek vojtapolasek changed the title RHEL: increase /boot partition size in kickstrts RHEL: increase /boot partition size in kickstarts Feb 2, 2026
@Mab879 Mab879 self-assigned this Feb 2, 2026
Mab879
Mab879 reviewed Feb 2, 2026
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for these to work with our tests don't we need to find 512 bytes from else where to give to /boot? IIRC we have ~20 GB of space in some of our testing VMs.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026 •
edited
Loading

ATEX Test Results

Test artifacts have been submitted to Testing Farm.

Results: View Test Results
Workflow Run: View Workflow Details

This comment was automatically generated by the ATEX workflow.

@vojtapolasek vojtapolasek mentioned this pull request Feb 3, 2026
Closed
@comps
Copy link
Collaborator

comps commented Feb 4, 2026

If you want to use reqpart on other places as well, without increasing the disk size requirements, just shrink / (if it's the biggest partition where /usr is not specified) and let it --grow, ie.

reqpart --add-boot
part pv.01 --size=1 --grow

# Create a Logical Volume Management (LVM) group (optional)
volgroup VolGroup pv.01

# Create particular logical volumes (optional)
logvol / --fstype=xfs --name=root --vgname=VolGroup --size=5000 --grow
...

I reduced the --size from 10240 (or 11264), since 5GB is definitely enough for a base / and --grow was already there.

@vojtapolasek vojtapolasek force-pushed the increase_boot_part_size_in_ks branch 2 times, most recently from f714f2a to e668a9c Compare February 5, 2026 13:09
Mab879
Mab879 reviewed Feb 5, 2026
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does reqpart set the needed flags for /boot? Based on the docs I think not?

products/rhel8/kickstart/ssg-rhel8-stig-ks.cfg Outdated
@@ -90,14 +90,14 @@ zerombr
clearpart --linux --initlabel

# Create primary system partitions (required for installs)
part /boot --fstype=xfs --size=512 --fsoptions="nodev,nosuid,noexec"
reqpart --add-boot
Copy link
Member

@Mab879 Mab879 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this set the fs options needed?

Copy link
Collaborator Author

@vojtapolasek vojtapolasek Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I did not realize this. I think it does not set anything. I guess we could use reqpart withouth --add-boot and keep the original way where we define /boot manually. I will check with SMEs.

@vojtapolasek vojtapolasek force-pushed the increase_boot_part_size_in_ks branch from e668a9c to 19f5083 Compare February 6, 2026 10:42
@vojtapolasek
Copy link
Collaborator Author

vojtapolasek commented Feb 6, 2026

I rewamped the PR.
I increase size of /boot to 2 gb, because that is actually what reqpart --add-boot does.
I keep the reqpart there because it helps to create proper partitions on EFI systems.
But still I define /boot manually because it allows me to set mount options.

@Mab879
Copy link
Member

Mab879 commented Feb 9, 2026

/packit build centos-stream-9-x86_64

Mab879
Mab879 requested changes Feb 9, 2026
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs one last rebase on latest master.

@vojtapolasek
rhel8: update kickstarts
f292779 
add reqpart
set /boot size to 2048
decrease initiali size of root partition so that we roughly fit into 20 gb size
@vojtapolasek
rhel9: modify kickstarts
0d862eb 
add reqpart
increase /boot to 2048
decrease / to at most 5120
@vojtapolasek
rhel8: align kickstart mount options with rules in profiles
9382ea8
@vojtapolasek
rhel9: align kickstarts with rules in the profile regarding mount opt…
c25a1ab 
…ions
@vojtapolasek vojtapolasek force-pushed the increase_boot_part_size_in_ks branch from 19f5083 to c25a1ab Compare February 10, 2026 09:19
@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026 •
edited
Loading

@vojtapolasek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-openshift-node-compliance c25a1ab link true /test e2e-aws-openshift-node-compliance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vojtapolasek
Copy link
Collaborator Author

vojtapolasek commented Feb 10, 2026

/packit retest-failed

1 similar comment
@Mab879
Copy link
Member

Mab879 commented Feb 10, 2026

/packit retest-failed

@Mab879
Copy link
Member

Mab879 commented Feb 10, 2026

/retest

@Mab879 Mab879 merged commit 03ada44 into ComplianceAsCode:master Feb 10, 2026
141 of 143 checks passed
@vojtapolasek vojtapolasek mentioned this pull request Feb 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels

bugfix Fixes to reported bugs. Kickstart Kickstart file updates. RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related.

Projects

None yet

Milestone

0.1.80

Development

Successfully merging this pull request may close these issues.

3 participants

@vojtapolasek @comps @Mab879