Add new rule disable_weak_deps#14173
Merged
Mab879 merged 2 commits intoComplianceAsCode:masterfrom Nov 25, 2025
Merged
Conversation
Mab879
requested changes
Nov 24, 2025
Member
Mab879
left a comment
There was a problem hiding this comment.
I added the following test:
$ cat linux_os/guide/system/software/updating/disable_weak_deps/tests/wrong_section.fail.sh
#!/bin/bash
cat <<EOF >/etc/dnf/dnf.conf
[notmain]
install_weak_deps = 0
EOF
And got
ERROR - Rule evaluation resulted in fail, instead of expected pass during final stage
ERROR - The check after remediation failed for rule 'xccdf_org.ssgproject.content_rule_disable_weak_deps'.
Member
|
Also, please fix the CI issues. |
This rule checks if weak package dependencies are allowed to be installed by DNF. This rule is added to RHEL 10 CIS profiles because it implements the requirement 1.2.1.5 of RHEL 10 CIS Benchmark v1.0.1. Resolves: https://issues.redhat.com/browse/OPENSCAP-6425
Collaborator
Author
|
I have added new test scenario, improved the bash remediation and fixed CI issues |
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mab879
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule checks if weak package dependencies are allowed to be installed by DNF. This rule is added to RHEL 10 CIS profiles because it implements the requirement 1.2.1.5 of RHEL 10 CIS Benchmark v1.0.1.
Resolves: https://issues.redhat.com/browse/OPENSCAP-6425