Remove pkg resources#14142
Conversation
Replaced pkg_resources with a custom RequirementParser. It implements just enough of pkg_resources.Requirement to work for our project. Fixes: ComplianceAsCode#13902
Claude code was used in part in creating this commit.
No longer needed as pkg_resources has been removed from the code based.
|
Skipping CI for Draft Pull Request. |
|
Leaving in draft state until we cut the branch for the 0.1.79 release, no need to make this change right before a release. |
|
@Mab879: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-openshift-node-compliance |
jan-cerny
left a comment
There was a problem hiding this comment.
Looks good to me. I haven't found any remaining use of pkg_resources in the project. Python unit tests passed locally.
Description:
Remove
pkg_resourcesusage from the code base and replace with custom solution.It might not be as featured as
pkg_resourcesbut due limitations on how the python packagepackagingis distributed this was the easiest to use.Rationale:
Fixes #13902
Review Hints: