Skip to content

SLE related fixes for pam_faillock configuration file#14131

Merged
teacup-on-rockingchair merged 6 commits intoComplianceAsCode:masterfrom
teacup-on-rockingchair:fix_pam_faillock_conf_sle
Nov 24, 2025
Merged

SLE related fixes for pam_faillock configuration file#14131
teacup-on-rockingchair merged 6 commits intoComplianceAsCode:masterfrom
teacup-on-rockingchair:fix_pam_faillock_conf_sle

Conversation

@teacup-on-rockingchair
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair commented Nov 17, 2025

Description:

  • Add definition for pam-faillock conf file location needed for SLE 15 and 16

Rationale:

  • Move pam-faillock config to variable in accounts_passwords_pam_faillock_deny_root rule
  • Move pam-faillock config to variable in pam_account_password_faillock template
  • Make sure ansible remediations for pam_faillock work in common-auth and common-account for sle
  • Make sure bash remediations for pam_faillock work in sle >=15
  • Update product stability files with new define for pam_faillock_conf_path

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review November 17, 2025 19:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 17, 2025
@teacup-on-rockingchair teacup-on-rockingchair added Ansible Ansible remediation update. Bash Bash remediation update. SLES SUSE Linux Enterprise Server product related. Update Template Issues or pull requests related to Templates updates. labels Nov 17, 2025
@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.79 milestone Nov 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2025

@teacup-on-rockingchair: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-openshift-node-compliance a87842e link true /test e2e-aws-openshift-node-compliance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

svet-se
svet-se approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@svet-se svet-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jan-cerny jan-cerny modified the milestones: 0.1.79, 0.1.80 Nov 20, 2025
dodys
dodys approved these changes Nov 24, 2025
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@teacup-on-rockingchair teacup-on-rockingchair merged commit b5ec005 into ComplianceAsCode:master Nov 24, 2025
137 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

@dodys dodys dodys approved these changes

@svet-se svet-se svet-se approved these changes

@matusmarhefka matusmarhefka Awaiting requested review from matusmarhefka matusmarhefka is a code owner

@vojtapolasek vojtapolasek Awaiting requested review from vojtapolasek vojtapolasek is a code owner

@jan-cerny jan-cerny Awaiting requested review from jan-cerny jan-cerny is a code owner

+1 more reviewer

@Xeicker Xeicker Xeicker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ansible Ansible remediation update. Bash Bash remediation update. SLES SUSE Linux Enterprise Server product related. Update Template Issues or pull requests related to Templates updates.

Projects

None yet

Milestone

0.1.80

Development

Successfully merging this pull request may close these issues.

6 participants

@teacup-on-rockingchair @Mab879 @dodys @Xeicker @svet-se @jan-cerny