Add: Ion Mobility data to Sage Reader#113
Merged
RalfG merged 7 commits intoCompOmics:mainfrom Mar 6, 2025
Merged
Conversation
- add ion mobility and predicted filed to test_psm obj - update expected hash in idxml test for outputed sage idxml
Co-authored-by: Ralf Gabriels <ralfg@hotmail.be>
rodvrees
approved these changes
Mar 6, 2025
RalfG
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent versions of Sage output includes the
ion_mobilityandpredicted_mobilitycolumns. I updated the Sage Reader to include these columns in the PSM object and the rescoring features set respectively. I updated the tests as well, I had to update the hash for the idxml test for the sage output, but all tests pass locally.This should also address this issue ms2rescore/issues/207. When trying to perform rescoring on immunopeptidomics bruker data, it would fail due to the
ion_mobilitycolumn missing in the PSM object.