-
Notifications
You must be signed in to change notification settings - Fork 383
MVVM Toolkit generators are broken on legacy style .csproj projects #540
Copy link
Copy link
Closed
Labels
blocking release 💥A major issue that's blocking a release and has to be fixedA major issue that's blocking a release and has to be fixedbuild 🔥Some changes or issues related to build infrastructureSome changes or issues related to build infrastructureexternal ⤴️Something related to or caused by an external projectSomething related to or caused by an external projectmvvm-toolkit 🧰Issues/PRs for the MVVM ToolkitIssues/PRs for the MVVM Toolkitpriority 🚩An issue or change that has priorityAn issue or change that has priority
Metadata
Metadata
Assignees
Labels
blocking release 💥A major issue that's blocking a release and has to be fixedA major issue that's blocking a release and has to be fixedbuild 🔥Some changes or issues related to build infrastructureSome changes or issues related to build infrastructureexternal ⤴️Something related to or caused by an external projectSomething related to or caused by an external projectmvvm-toolkit 🧰Issues/PRs for the MVVM ToolkitIssues/PRs for the MVVM Toolkitpriority 🚩An issue or change that has priorityAn issue or change that has priority
See: dotnet/roslyn#65996
Also probably related to: #495. The MVVM Toolkit generators are currently completely broken on legacy style .csproj projects:
@sharwell can you elaborate on the part in bold? I'd like us to update the .targets file we're shipping in the generator so that if component version is not supported we can just remove one of the two analyzer references ourselves. This would allow us to keep leveraging the component versioning system to support older Roslyn versions while still having the performance improvements on new versions, and also to keep supporting customers using legacy style .csproj projects 🙂
Regression
Yes, 8.1 introduced this issue
Steps to reproduce
Expected behavior
It should build normally
IDE and version
VS 2022
Nuget packages
Nuget package version(s)
8.1.0 Preview 1