This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Add design metadata for RichSuggestBox#4200
Merged
michael-hawker merged 3 commits intoCommunityToolkit:mainfrom Aug 31, 2021
Merged
Add design metadata for RichSuggestBox#4200michael-hawker merged 3 commits intoCommunityToolkit:mainfrom
michael-hawker merged 3 commits intoCommunityToolkit:mainfrom
Conversation
|
Thanks huynhsontung for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Member
|
Thanks @huynhsontung! @Nirmal4G this look good to you? |
Nirmal4G
approved these changes
Aug 31, 2021
Contributor
Nirmal4G
left a comment
There was a problem hiding this comment.
Looks good to me 👍. I thought of filling the gaps with source generators but hey… this is not so bad in the meantime. I'll also add basic support for media controls.
Thanks so much for this.🚀
michael-hawker
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding design metadata for
RichSuggestBox.PR Type
What kind of change does this PR introduce?
What is the current behavior?
No metadata for
RichSuggestBoxcontrol.What is the new behavior?
Design metadata is added for
RichSuggestBoxPR Checklist
Please check if your PR fulfills the following requirements:
Other information