This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Enable item renaming and add tests for ApplicationDataStorageHelper#4173
Merged
michael-hawker merged 4 commits intomainfrom Aug 19, 2021
Merged
Enable item renaming and add tests for ApplicationDataStorageHelper#4173michael-hawker merged 4 commits intomainfrom
michael-hawker merged 4 commits intomainfrom
Conversation
|
Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
XAML-Knight
approved these changes
Aug 13, 2021
michael-hawker
approved these changes
Aug 19, 2021
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is currently no methods for renaming items via the
IFileStorageHelperinterface.Also, the
ApplicationDataStorageHelperneeds more tests to validate that the file storage functionality is working as expected.What is the new behavior?
To support renaming items, I've added a new method
IFileStorageHelper.TryRenameItemAsync.In addition, I've also updated the
IFileStorageHelper.DeleteItemAsyncmethod toTryDeleteItemAsyncto match the convention. It seems reasonable to expect that the file intended for deletion does not already exist, so the consumer should be able to handle this gracefully, without exceptions.Lastly, while adding tests for
ApplicationDataStorageHelperI discovered that it doesn't handle items in sub-folders very well. So I've made some fixes there as well to support CRUD operations with files/folders in sub-directories.PR Checklist
Please check if your PR fulfills the following requirements:
Other information