Test IncrementalLoadingCollection itemsPerPage ctor param #4023
Test IncrementalLoadingCollection itemsPerPage ctor param #4023michael-hawker merged 1 commit intoCommunityToolkit:mainfrom Rosuavio:ilc-pageSize
Conversation
|
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
@RosarioPulella was this just to check tests, should we commit this or are we waiting on something else still? |
|
The original intention was to explore |
| for (var pageNum = 1; pageNum <= pages; pageNum++) | ||
| { | ||
| requests.Add(collection.LoadMoreItemsAsync(0).AsTask() | ||
| .ContinueWith(t => Assert.IsTrue(t.IsCompletedSuccessfully))); |
There was a problem hiding this comment.
Should we check the interim results for pageSize here as well as we're passing that into the test now?
There was a problem hiding this comment.
I am not sure its that easy since these calls are happening asynchronously and we would need to test ageist collection which will be changing as these tasks complete.
Tests different items per page for
IncrementalLoadingCollectionPR Type
What kind of change does this PR introduce?
Tests different values for
itemsPerPagein the IncrementalLoadingCollection ctor.What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information