Conversation
Add info in readme for building the toolkit repo and dependencies required.
|
Thanks for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
@azchohfi we noticed that 4.6.2 was called out for Marcus in a build step too. Could we have a dependency mismatch somewhere on both 4.6.1 and 4.6.2? What is the config line that pulls that in, where does that live? |
Co-Authored-By: Vijay Nirmal <pon.vijaynirmal@outlook.com>
clairernovotny
left a comment
There was a problem hiding this comment.
LGTM, the only suggestion I would have is to look into moving the CI package feed to Azure Artifacts instead of MyGet
|
@clairernovotny Thanks Claire! I know there's also GitHub packages as well, maybe it's best we open a separate issue to track that discussion and understand the pros/cons of each solution and the effort involved in moving over to them? |
|
Thanks @azchohfi I'll update this guidance to call out the different SDKs needed for building the toolkit vs. the sample app. I guess ideally we should converge to the same one, I just know we're not using anything specific in the newer SDKs currently. |
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
|
@azchohfi this look better for now until we update and converge later? |
Add info in readme for building the toolkit repo and dependencies required.
PR Type
What kind of change does this PR introduce?