Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

Some fixes for TokenizingTextBox#3054

Merged
azchohfi merged 9 commits intomasterfrom
mhawker/tokenizing-updates
Oct 31, 2019
Merged

Some fixes for TokenizingTextBox#3054
azchohfi merged 9 commits intomasterfrom
mhawker/tokenizing-updates

Conversation

@michael-hawker
Copy link
Copy Markdown
Member

@michael-hawker michael-hawker commented Oct 31, 2019

What is the current behavior?

No way to strongly type strings.
Issue using keyboard to navigate selections.

What is the new behavior?

Fixed both of the above
Improves Sample

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Adds copy of https://github.com/PedroLamas/DeferredEvents library, but for UWP TypedEventHandlers as well and cancellable events.

TODO: We still have an issue with not being able to programatically add tokens. ☹

@azchohfi azchohfi merged commit a8d7690 into master Oct 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the mhawker/tokenizing-updates branch October 31, 2019 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants