Skip to content

Fixes #146 - Add example comments for a Toolkit package example#184

Merged
michael-hawker merged 1 commit intomainfrom
llama/example-dependency
Jul 6, 2022
Merged

Fixes #146 - Add example comments for a Toolkit package example#184
michael-hawker merged 1 commit intomainfrom
llama/example-dependency

Conversation

@michael-hawker
Copy link
Copy Markdown
Member

@michael-hawker michael-hawker commented Jul 5, 2022 •
edited
Loading

Fixes #146

Note: that most likely someone will want to abstract/wrap an unsealed toolkit component to expose it under a common namespace to be used in their component's XAML. We'll want to add this to the wiki, at least until we get an 8.0 build which has everything together already for this, e.g.

#if WINAPPSDK
using ToolkitWP = CommunityToolkit.WinUI.UI.Controls.WrapPanel;
#else
using ToolkitWP = Microsoft.Toolkit.Uwp.UI.Controls.WrapPanel;
#endif

namespace CommunityToolkit.Labs.ExperimentName;

/// <summary>
/// Provide an abstraction around the Toolkit WrapPanel for both UWP and WinUI 3 in the same namespace (until 8.0).
/// </summary>
public partial class WrapPanel: ToolkitWP
{
}

@michael-hawker
Fixes #146 - Add example comments for a Toolkit package example of be…
b0ab722 
…ing included in props file for src

Note that most likely someone will want to abstract/wrap an unsealed toolkit component to expose it under a common namespace to be used in their component's XAML. We'll want to add this to the wiki, at least until we get an 8.0 build which has everything together already for this.
@michael-hawker michael-hawker added documentation 📃 Improvements or additions to documentation templating labels Jul 5, 2022
@michael-hawker michael-hawker added this to the Initial Release milestone Jul 5, 2022
@Arlodotexe Arlodotexe self-requested a review July 5, 2022 23:50
Arlodotexe
Arlodotexe approved these changes Jul 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michael-hawker michael-hawker merged commit c003a5d into main Jul 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the llama/example-dependency branch July 6, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees

No one assigned

Labels

documentation 📃 Improvements or additions to documentation templating

Projects

None yet

Milestone

Initial Release

Development

Successfully merging this pull request may close these issues.

Add common dependencies in new Dependencies props in template for ease of inclusion

2 participants

@michael-hawker @Arlodotexe