Skip to content

Adding login step for docker#561

Merged
Alirexaa merged 7 commits into
mainfrom
aaronpowell/issue556
Mar 11, 2025
Merged

Adding login step for docker#561
Alirexaa merged 7 commits into
mainfrom
aaronpowell/issue556

Conversation

@aaronpowell

@aaronpowell aaronpowell commented Mar 11, 2025

Copy link
Copy Markdown
Member

Fixes #556

Closes #<ISSUE_NUMBER>

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@aaronpowell aaronpowell requested a review from Alirexaa March 11, 2025 03:46
Alirexaa
Alirexaa approved these changes Mar 11, 2025
View reviewed changes

@Alirexaa Alirexaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this works.

@Alirexaa

Alirexaa commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@aaronpowell, unrelated to this PR, It seems the Azure API key expired.

Run dotnet nuget push  "D:\a\Aspire\Aspire/**/*.nupkg"  --api-key dummy  --source PullRequests  --skip-duplicate
Pushing CommunityToolkit.Aspire.EventStore.9.2.2-alpha.1150.nupkg to 'https://pkgs.dev.azure.com/dotnet/696bc9fd-f160-[4](https://github.com/CommunityToolkit/Aspire/actions/runs/13780300647/job/38537504988?pr=561#step:4:5)e97-a1bd-7cbbb3b58f66/_packaging/9a4910fe-1261-4bea-a037-12bad850ab66/nuget/v2/'...
  PUT https://pkgs.dev.azure.com/dotnet/696bc9fd-f160-4e97-a1bd-7cbbb3b58f66/_packaging/9a4910fe-1261-4bea-a037-12bad850ab66/nuget/v2/
  Unauthorized https://pkgs.dev.azure.com/dotnet/696bc9fd-f160-4e97-a1bd-7cbbb3b[5](https://github.com/CommunityToolkit/Aspire/actions/runs/13780300647/job/38537504988?pr=561#step:4:6)8f66/_packaging/9a4910fe-12[6](https://github.com/CommunityToolkit/Aspire/actions/runs/13780300647/job/38537504988?pr=561#step:4:7)1-4bea-a037-12bad850ab66/nuget/v2/ 318ms
error: Response status code does not indicate success: 401 (Unauthorized).

@Alirexaa Alirexaa enabled auto-merge (squash) March 11, 2025 09:05
@Alirexaa Alirexaa mentioned this pull request Mar 11, 2025
Closed
@aaronpowell

aaronpowell commented Mar 11, 2025

Copy link
Copy Markdown
Member Author

@aaronpowell, unrelated to this PR, It seems the Azure API key expired.

Run dotnet nuget push  "D:\a\Aspire\Aspire/**/*.nupkg"  --api-key dummy  --source PullRequests  --skip-duplicate
Pushing CommunityToolkit.Aspire.EventStore.9.2.2-alpha.1150.nupkg to 'https://pkgs.dev.azure.com/dotnet/696bc9fd-f160-[4](https://github.com/CommunityToolkit/Aspire/actions/runs/13780300647/job/38537504988?pr=561#step:4:5)e97-a1bd-7cbbb3b58f66/_packaging/9a4910fe-1261-4bea-a037-12bad850ab66/nuget/v2/'...
  PUT https://pkgs.dev.azure.com/dotnet/696bc9fd-f160-4e97-a1bd-7cbbb3b58f66/_packaging/9a4910fe-1261-4bea-a037-12bad850ab66/nuget/v2/
  Unauthorized https://pkgs.dev.azure.com/dotnet/696bc9fd-f160-4e97-a1bd-7cbbb3b[5](https://github.com/CommunityToolkit/Aspire/actions/runs/13780300647/job/38537504988?pr=561#step:4:6)8f66/_packaging/9a4910fe-12[6](https://github.com/CommunityToolkit/Aspire/actions/runs/13780300647/job/38537504988?pr=561#step:4:7)1-4bea-a037-12bad850ab66/nuget/v2/ 318ms
error: Response status code does not indicate success: 401 (Unauthorized).

Yep, should be fixed. I raised another issue and spoke to the Microsoft person who manages the Azure DevOps, they said the token has been refreshed

@github-actions

github-actions Bot commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
CommunityToolkit.Aspire.EventStore 100% 100% 46 ✔
CommunityToolkit.Aspire.GoFeatureFlag 100% 97% 74 ✔
CommunityToolkit.Aspire.Hosting.ActiveMQ 80% 40% 100 ✔
CommunityToolkit.Aspire.Hosting.ActiveMQ.MassTransit 1% 0% 14 ❌
CommunityToolkit.Aspire.Hosting.Azure.Dapr 3% 0% 726 ❌
CommunityToolkit.Aspire.Hosting.Azure.Dapr.Redis 93% 73% 58 ✔
CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder 100% 100% 22 ✔
CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps 100% 100% 28 ✔
CommunityToolkit.Aspire.Hosting.Bun 82% 69% 58 ✔
CommunityToolkit.Aspire.Hosting.Dapr 63% 49% 676 ➖
CommunityToolkit.Aspire.Hosting.DbGate 96% 50% 18 ✔
CommunityToolkit.Aspire.Hosting.Deno 84% 75% 72 ✔
CommunityToolkit.Aspire.Hosting.EventStore 94% 100% 18 ✔
CommunityToolkit.Aspire.Hosting.GoFeatureFlag 93% 50% 18 ✔
CommunityToolkit.Aspire.Hosting.Golang 94% 50% 16 ✔
CommunityToolkit.Aspire.Hosting.Java 69% 72% 120 ➖
CommunityToolkit.Aspire.Hosting.LavinMQ 78% 50% 18 ➖
CommunityToolkit.Aspire.Hosting.LavinMQ.MassTransit 1% 0% 14 ❌
CommunityToolkit.Aspire.Hosting.MailPit 91% 50% 14 ✔
CommunityToolkit.Aspire.Hosting.Meilisearch 73% 57% 50 ➖
CommunityToolkit.Aspire.Hosting.MongoDB.Extensions 96% 83% 36 ✔
CommunityToolkit.Aspire.Hosting.Ngrok 52% 35% 82 ❌
CommunityToolkit.Aspire.Hosting.NodeJS.Extensions 90% 69% 96 ✔
CommunityToolkit.Aspire.Hosting.Ollama 65% 66% 156 ➖
CommunityToolkit.Aspire.Hosting.PapercutSmtp 92% 50% 10 ✔
CommunityToolkit.Aspire.Hosting.PostgreSQL.Extensions 100% 91% 44 ✔
CommunityToolkit.Aspire.Hosting.Python.Extensions 68% 55% 90 ➖
CommunityToolkit.Aspire.Hosting.RavenDB 62% 44% 132 ➖
CommunityToolkit.Aspire.Hosting.Redis.Extensions 100% 83% 36 ✔
CommunityToolkit.Aspire.Hosting.Rust 94% 83% 16 ✔
CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects 74% 62% 118 ➖
CommunityToolkit.Aspire.Hosting.Sqlite 97% 91% 54 ✔
CommunityToolkit.Aspire.Hosting.SqlServer.Extensions 100% 83% 36 ✔
CommunityToolkit.Aspire.MassTransit.RabbitMQ 100% 100% 30 ✔
CommunityToolkit.Aspire.Meilisearch 97% 92% 68 ✔
CommunityToolkit.Aspire.Microsoft.Data.Sqlite 37% 27% 194 ❌
CommunityToolkit.Aspire.Microsoft.EntityFrameworkCore.Sqlite 51% 50% 92 ❌
CommunityToolkit.Aspire.OllamaSharp 71% 64% 98 ➖
CommunityToolkit.Aspire.RavenDB.Client 60% 53% 237 ➖
Summary 61% (5208 / 8499) 46% (1459 / 3206) 3785 ➖

Minimum allowed line rate is 60%

@Alirexaa Alirexaa merged commit 2947504 into main Mar 11, 2025
@Alirexaa Alirexaa deleted the aaronpowell/issue556 branch March 11, 2025 09:15
@Alirexaa Alirexaa temporarily deployed to azure-artifacts March 11, 2025 09:15 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alirexaa Alirexaa Alirexaa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failure Test: Dockerhub rate limit has been reached

2 participants

@aaronpowell @Alirexaa