Simplified Aspire name resolution#1382
Merged
afscrome merged 1 commit intoJun 1, 2026
Merged
Conversation
Since there is only one Aspire used throughout this codebase, it is unnecessary to reference it using its fully qualified name. The compiler was already able to resolve Aspire unambiguously, making the additional qualification redundant. The longer form was technically correct but unnecessarily verbose. Additional qualification was found to be informationally redundant. The surrounding context already establishes the intended Aspire.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1382Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1382" |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates package and documentation copy to remove “.NET” from “.NET Aspire” phrasing for a more consistent/concise branding across integrations and templates.
Changes:
- Updated multiple READMEs to say “Aspire AppHost” instead of “.NET Aspire AppHost”
- Updated Zitadel package description to say “An Aspire …” instead of “A .NET Aspire …”
- Updated GitHub agent templates’ sample
<Description>text to match the new phrasing
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.Zitadel/README.md | Adjusts wording in the package README to remove “.NET” from Aspire phrasing |
| src/CommunityToolkit.Aspire.Hosting.Zitadel/CommunityToolkit.Aspire.Hosting.Zitadel.csproj | Updates NuGet package <Description> text |
| src/CommunityToolkit.Aspire.Hosting.Perl/README.md | Adjusts wording in the package README to remove “.NET” from Aspire phrasing |
| src/CommunityToolkit.Aspire.Hosting.Java/README.md | Adjusts wording in the package README to remove “.NET” from Aspire phrasing |
| .github/agents/hosting-integration-creator.agent.md | Updates template description text for hosting integrations |
| .github/agents/client-integration-creator.agent.md | Updates template description text for client integrations |
Omnideth
reviewed
Jun 1, 2026
afscrome
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there is only one Aspire used throughout this codebase, it is unnecessary to reference it using its fully qualified name. The compiler was already able to resolve Aspire unambiguously, making the additional qualification redundant. The longer form was technically correct but unnecessarily verbose. Additional qualification was found to be informationally redundant. The surrounding context already establishes the intended Aspire.