Skip to content

Update sample to use latest SDK#1335

Merged
aaronpowell merged 2 commits into
CommunityToolkit:mainfrom
ErikEJ:sqlproj-sample-sdk
May 22, 2026
Merged

Update sample to use latest SDK#1335
aaronpowell merged 2 commits into
CommunityToolkit:mainfrom
ErikEJ:sqlproj-sample-sdk

Conversation

@ErikEJ

@ErikEJ ErikEJ commented May 21, 2026

Copy link
Copy Markdown
Contributor

Closes #<ISSUE_NUMBER>

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)

Other information

@ErikEJ ErikEJ requested a review from jmezach as a code owner May 21, 2026 08:58
Copilot AI review requested due to automatic review settings May 21, 2026 08:58
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1335

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1335"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SQL Database Projects example to align with a newer MSBuild SqlProj SDK and newer SQL Server target, keeping the sample current within the examples/ area of the repo.

Changes:

  • Bumps MSBuild.Sdk.SqlProj from 3.2.0 to 4.2.0.
  • Updates the database target from Sql150 to Sql160.
  • Removes empty placeholder ItemGroup/PropertyGroup blocks from the sample .csproj.

Comment thread examples/sql-database-projects/SdkProject/SdkProject.csproj
Comment thread examples/sql-database-projects/SdkProject/SdkProject.csproj Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@jmezach jmezach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronpowell aaronpowell merged commit 8751bf6 into CommunityToolkit:main May 22, 2026
238 of 247 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants