Add polyglot exports for mailpit#1184
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1184Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1184" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds polyglot AspireExport coverage for the MailPit hosting integration, plus a new TypeScript ValidationAppHost under playground/ to validate the generated exports.
Changes:
- Add
[AspireExport]attributes to MailPit hosting extension methods and expose MailPit resource properties for polyglot consumption. - Introduce a TypeScript ValidationAppHost (tsconfig/package/apphost/runsettings/.aspire settings) for MailPit polyglot export validation.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.MailPit/MailPitHostingExtension.cs | Adds AspireExport annotations to hosting extension methods. |
| src/CommunityToolkit.Aspire.Hosting.MailPit/MailPitContainerResource.cs | Exposes resource properties via AspireExport for polyglot access. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.MailPit/ValidationAppHost/tsconfig.json | TypeScript configuration for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.MailPit/ValidationAppHost/package.json | Node package manifest/scripts for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.MailPit/ValidationAppHost/package-lock.json | Lockfile for reproducible installs. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.MailPit/ValidationAppHost/apphost.ts | Validation script exercising exported APIs and exposed properties. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.MailPit/ValidationAppHost/apphost.run.json | Run profile settings for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.MailPit/ValidationAppHost/.aspire/settings.json | Aspire polyglot settings pointing at MailPit package and apphost entrypoint. |
Files not reviewed (1)
- playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.MailPit/ValidationAppHost/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
| [ResourceName] string name, | ||
| int? httpPort = null, | ||
| int? smtpPort = null) | ||
| { |
Comment on lines
+1
to
4
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
||
| namespace Aspire.Hosting.ApplicationModel; | ||
|
|
| "type": "module", | ||
| "scripts": { | ||
| "start": "aspire run", | ||
| "build": "tsc", |
Comment on lines
+4
to
6
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
||
| namespace Aspire.Hosting; |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5e31c6e to
e4d650c
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Minimum allowed line rate is |
aaronpowell
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AspireExport coverage and a matching TypeScript validation apphost for mailpit.