Add polyglot exports for bun#1183
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1183Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1183" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds AspireExport coverage for the Bun hosting integration and introduces a TypeScript polyglot ValidationAppHost to exercise the exported APIs.
Changes:
- Add
[AspireExport]annotations to Bun hosting extension methods and suppress the experimental warning. - Make
WithBunPackageInstallationidempotent by reusing an existing installer resource builder. - Add a new TypeScript ValidationAppHost (including a minimal bun app) plus npm/tsconfig/run-profile scaffolding.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.Bun/BunAppExtensions.cs | Adds AspireExport attributes and installer reuse logic for polyglot export coverage. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Bun/ValidationAppHost/tsconfig.json | TS compiler settings for the validation apphost project. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Bun/ValidationAppHost/package.json | npm scripts and dependencies for running/building the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Bun/ValidationAppHost/package-lock.json | Lockfile capturing resolved npm dependency graph. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Bun/ValidationAppHost/bun-app/package.json | Minimal Bun app package metadata used by the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Bun/ValidationAppHost/bun-app/index.ts | Minimal Bun app entry point to keep the process alive for validation. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Bun/ValidationAppHost/apphost.ts | Validation apphost exercising exported Bun APIs (addBunApp + package installation). |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Bun/ValidationAppHost/apphost.run.json | Local run profile configuration for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Bun/ValidationAppHost/.aspire/settings.json | Aspire settings pointing at the TS apphost and package under test. |
Files not reviewed (1)
- playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Bun/ValidationAppHost/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+1
to
+3
| #pragma warning disable ASPIREATS001 // AspireExport is experimental. | ||
|
|
||
| using Aspire.Hosting.ApplicationModel; |
| @@ -0,0 +1,36 @@ | |||
| import { createBuilder } from './.modules/aspire.js'; | |||
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1fbfcc4 to
cf51e38
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Minimum allowed line rate is |
aaronpowell
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AspireExport coverage and a matching TypeScript validation apphost for bun.