Add polyglot exports for lavinmq#1182
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1182Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1182" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Aspire ATS (polyglot) export metadata for the LavinMQ hosting integration and introduces a TypeScript ValidationAppHost to validate the generated TypeScript surface area for this package.
Changes:
- Annotate LavinMQ extension methods/resources with
[AspireExport]and suppress the experimental diagnostic. - Expose LavinMQ resource properties for polyglot access (
ExposeProperties = true+ publicPrimaryEndpoint). - Add a TypeScript ValidationAppHost (generated
.modulesSDK + apphost script + Node project files).
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.LavinMQ/LavinMQHostingExtension.cs | Adds [AspireExport] annotations for addLavinMQ, withDataVolume, withDataBindMount and suppresses ASPIREATS001. |
| src/CommunityToolkit.Aspire.Hosting.LavinMQ/LavinMQContainerResource.cs | Marks resource as exportable (ExposeProperties = true) and exposes PrimaryEndpoint publicly for generated property access. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.LavinMQ/ValidationAppHost/apphost.ts | Validation script exercising exported APIs and exported properties. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.LavinMQ/ValidationAppHost/aspire.config.json | Adds an Aspire config for running the TS apphost (currently pinned to a timestamped package version + local ports). |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.LavinMQ/ValidationAppHost/apphost.run.json | Run profile settings for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.LavinMQ/ValidationAppHost/package.json | Node/TS project definition for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.LavinMQ/ValidationAppHost/package-lock.json | Dependency lock for reproducible installs. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.LavinMQ/ValidationAppHost/tsconfig.json | TS compiler configuration for apphost + generated modules. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.LavinMQ/ValidationAppHost/.modules/* | Generated TypeScript SDK + transport layer used by the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.LavinMQ/ValidationAppHost/.aspire/settings.json | Aspire settings for the validation apphost and local package resolution. |
Files not reviewed (1)
- playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.LavinMQ/ValidationAppHost/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+6
to
+7
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
Comment on lines
+1
to
+2
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
| await bindBroker.withDataBindMount(bindMountPath); | ||
|
|
||
| // ---- Property access on LavinMQContainerResource (ExposeProperties = true) ---- | ||
| const volumeBrokerResource = await volumeBroker; |
f17c015 to
c81b07f
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1bbfa90 to
18dcd4e
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aaronpowell
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AspireExport coverage and a matching TypeScript validation apphost for lavinmq.