Add polyglot exports for adminer#1180
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1180Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1180" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds polyglot AspireExport coverage for the Adminer hosting integration and introduces a matching TypeScript ValidationAppHost under the playground polyglot samples to validate the generated exports.
Changes:
- Annotate
AddAdminer/WithHostPortwith[AspireExport]to enable polyglot export generation. - Add a new TypeScript
ValidationAppHostsample for Adminer (TS config, npm manifests, run profile, and apphost entrypoint).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.Adminer/AdminerBuilderExtensions.cs | Adds [AspireExport] attributes and suppresses the experimental diagnostic to enable polyglot exports. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Adminer/ValidationAppHost/tsconfig.json | TypeScript compiler configuration for the Adminer validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Adminer/ValidationAppHost/package.json | NPM scripts and dependencies for running/building the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Adminer/ValidationAppHost/package-lock.json | Locks dependency graph for reproducible validation apphost installs. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Adminer/ValidationAppHost/apphost.ts | Validation apphost that exercises the exported addAdminer / withHostPort APIs. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Adminer/ValidationAppHost/apphost.run.json | Local run profile for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Adminer/ValidationAppHost/.aspire/settings.json | Aspire settings pointing to the TS apphost and the polyglot package version. |
Files not reviewed (1)
- playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Adminer/ValidationAppHost/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+4
to
+5
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
d485bc9 to
9abc6ea
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Minimum allowed line rate is |
aaronpowell
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AspireExport coverage and a matching TypeScript validation apphost for adminer.