Add polyglot exports for flyway#1179
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1179Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1179" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds TypeScript export surface for the Flyway hosting integration so it can be used from polyglot (TypeScript) AppHost scenarios, and introduces a corresponding TypeScript ValidationAppHost playground project.
Changes:
- Annotate Flyway builder APIs with
[AspireExport]to exposeaddFlywayandwithTelemetryOptInto TypeScript consumers. - Add a TypeScript ValidationAppHost (configs, lockfile, sample migrations, and apphost) to validate the exported API end-to-end.
- Suppress
ASPIREATS001warnings for the experimental export attribute (currently done via file-scoped pragma).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.Flyway/FlywayResourceBuilderExtensions.cs | Exports withTelemetryOptIn for TypeScript via AspireExport; adds ASPIREATS001 suppression. |
| src/CommunityToolkit.Aspire.Hosting.Flyway/DistributedApplicationBuilderExtensions.cs | Exports addFlyway for TypeScript via AspireExport; adds ASPIREATS001 suppression. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Flyway/ValidationAppHost/tsconfig.json | TypeScript compilation configuration for the ValidationAppHost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Flyway/ValidationAppHost/package.json | NPM project definition and scripts for running/building the ValidationAppHost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Flyway/ValidationAppHost/package-lock.json | Lockfile for the ValidationAppHost dependencies. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Flyway/ValidationAppHost/migrations/V1__placeholder.sql | Placeholder Flyway migration script. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Flyway/ValidationAppHost/apphost.ts | Example TypeScript apphost that uses addFlyway and withTelemetryOptIn. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Flyway/ValidationAppHost/apphost.run.json | Local run profile configuration for the ValidationAppHost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Flyway/ValidationAppHost/.aspire/settings.json | Aspire polyglot settings referencing the Flyway package. |
Files not reviewed (1)
- playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Flyway/ValidationAppHost/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+4
to
+5
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
Comment on lines
+3
to
+4
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
0b128dd to
26ba4ab
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Minimum allowed line rate is |
aaronpowell
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AspireExport coverage and a matching TypeScript validation apphost for flyway.