Add polyglot exports for dbgate#1178
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1178Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1178" |
0b4c699 to
4f07e28
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds AspireExport coverage for the DbGate hosting integration and introduces a TypeScript validation AppHost to exercise the generated polyglot surface area.
Changes:
- Annotate DbGate resource APIs with
[AspireExport]and enable exported property access onDbGateContainerResource. - Add a TypeScript ValidationAppHost project (tsconfig/package files, apphost entrypoint, run profile, and Aspire settings).
- Include a compiled
dist/apphost.jsoutput alongside the TypeScript source.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.DbGate/DbGateContainerResource.cs | Enables AspireExport property exposure for DbGate resource. |
| src/CommunityToolkit.Aspire.Hosting.DbGate/DbGateBuilderExtensions.cs | Exports DbGate builder extension methods for polyglot generation. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.DbGate/ValidationAppHost/tsconfig.json | TypeScript compiler configuration for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.DbGate/ValidationAppHost/package.json | NPM scripts/deps for running/typechecking the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.DbGate/ValidationAppHost/package-lock.json | Lockfile for deterministic installs. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.DbGate/ValidationAppHost/apphost.ts | TypeScript validation apphost that calls exported APIs and accesses exposed properties. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.DbGate/ValidationAppHost/dist/apphost.js | Emitted JS build output of the apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.DbGate/ValidationAppHost/apphost.run.json | Run profile/environment for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.DbGate/ValidationAppHost/.aspire/settings.json | Aspire settings pointing to the TS apphost and package under test. |
Files not reviewed (1)
- playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.DbGate/ValidationAppHost/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+1
to
5
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
||
| namespace Aspire.Hosting.ApplicationModel; | ||
|
|
||
| /// <summary> |
Comment on lines
+4
to
6
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
||
| namespace Aspire.Hosting; |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
72893ff to
cb3ed29
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aaronpowell
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AspireExport coverage and a matching TypeScript validation apphost for dbgate.