Skip to content

UmamiResource should implement IResourceWithServiceDiscovery #1149

@lvde0

Description

@lvde0

Related to an existing integration?

Yes

Existing integration

Umami

Overview

It probably makse sense to implement IResourceWithServiceDiscovery to make referencing it from another resource or YarpCluster easier.

Usage example

From the example:

.WithEnvironment("VITE_UMAMI_ENDPOINT", umami.GetEndpoint("http"))

could simply be:

.WithEnvironment("VITE_UMAMI_ENDPOINT", umami)

Breaking change?

No

Alternatives

N/A

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions