This repository was archived by the owner on Apr 28, 2026. It is now read-only.
fix(inventory): prevent ammo from creating invalid metadata when removed from weapons#39
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ammo metadata was always passed with type (falsey value if no special ammo present), however table.matches does shallow check, and even if type = nil exists, it will result in mismatch of metadata.
I think this fix is probably slightly better than updating metadata checks, as I think the behaviour is probably predictable as it currently is.
This change ensures that metadata is only passed when a valid
specialAmmovalueexists, avoiding the creation of
{ type = nil }and allowing ammo to stackcorrectly with existing items.