dev/multi-platform refactor #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re to prepare for moving all classes
…to its most important compontents for all platforms
…dNode to return the proper LiteralCommandNode
Also included an example of its interactions with Bukkit-specific arguments by implementing BukkitPlatform via NMS
…plement for Bukkit, make default arguments compile nicely
Fix BukkitBlockCommandSender by making it extend AbstractBlockCommandSender (not AbstractPlayer)
…t.fromKey to BukkitPlatform (for now?)
…th getSenderForCommand. Implement NMS 1.19 and 1.18 (as a proof of concept)
…the rest of bukkit NMS
# Conflicts: # commandapi-documentation-code/src/test/dev/jorel/commandapi/examples/java/Examples.java # commandapi-documentation-code/src/test/dev/jorel/commandapi/examples/kotlin/Examples.kt # commandapi-platforms/commandapi-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/EnvironmentArgument.java # commandapi-platforms/commandapi-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/ListArgument.java # commandapi-platforms/commandapi-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/arguments/ListTextArgument.java # commandapi-platforms/commandapi-bukkit/commandapi-bukkit-nms/commandapi-bukkit-1.13.1/src/main/java/dev/jorel/commandapi/nms/NMS_1_13_1.java # commandapi-platforms/commandapi-bukkit/commandapi-bukkit-nms/commandapi-bukkit-1.13/src/main/java/dev/jorel/commandapi/nms/NMS_1_13.java # commandapi-platforms/commandapi-bukkit/commandapi-bukkit-nms/commandapi-bukkit-1.14/src/main/java/dev/jorel/commandapi/nms/NMS_1_14.java # commandapi-platforms/commandapi-bukkit/commandapi-bukkit-nms/commandapi-bukkit-1.15/src/main/java/dev/jorel/commandapi/nms/NMS_1_15.java # commandapi-platforms/commandapi-bukkit/commandapi-bukkit-nms/commandapi-bukkit-1.16.1/src/main/java/dev/jorel/commandapi/nms/NMS_1_16_R1.java
# Conflicts: # commandapi-documentation-code/src/main/dev/jorel/commandapi/examples/java/Examples.java
… the static get method of the CommandAPIPlatform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.