Fix JSON serialization error in bulk import fail info API#2119
Merged
ltdrdata merged 2 commits intoComfy-Org:draft-v4from Sep 3, 2025
Merged
Fix JSON serialization error in bulk import fail info API#2119ltdrdata merged 2 commits intoComfy-Org:draft-v4from
ltdrdata merged 2 commits intoComfy-Org:draft-v4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/v2/customnode/import_fail_info_bulkendpoint was throwing a JSON serialization error:Root Cause
The error occurred due to a mismatch between the internal data structure and the API specification:
Internal data structure (
cm_global.error_dict):{ 'name': 'node-name', 'path': '/path/to/node', 'msg': 'error message' }API spec expects (
ImportFailInfoItem):{ 'error': 'error string', 'traceback': 'traceback string' }The code was trying to serialize the Pydantic model
ImportFailInfoBulkResponsewhich contained incompatible data structures, causing the serialization failure.Solution
cm_global.error_dictformat to match the API specificationmsgfield toerrorfieldtracebackfield when not presentChanges Made
Added data transformation in the bulk endpoint to convert error dict format:
Removed problematic Pydantic model serialization:
return web.json_response(response_data.root)return web.json_response(results, content_type="application/json")Testing
Tested with the following curl command and confirmed it returns proper JSON response without errors:
Impact