Minor code fixes to DynamoDS#9667 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparajit-pratap
commented
May 15, 2019
| } | ||
| } | ||
|
|
||
| if (null == astNodes) |
Author
There was a problem hiding this comment.
Removed unreachable code.
aparajit-pratap
commented
May 15, 2019
| } | ||
|
|
||
| workspace.MarkNodesAsModifiedAndRequestRun(nodes); | ||
| workspace.MarkNodesAsModifiedAndRequestRun(nodes, true); |
Author
There was a problem hiding this comment.
We need to ensure we pass true to the second parameter (which otherwise defaults to false) since we need to force-execute the node again (make sure it actually runs a second time but this time with the timing turned on). If this node is not made to force execute, delta compute will just skip it as it has already been executed before. This might explain the zero time execution.
aparajit-pratap
commented
May 15, 2019
| } | ||
| } | ||
|
|
||
| protected void AssertNonNull(string guid) |
Author
There was a problem hiding this comment.
Added new test utility method to test if any node is non null. Noticed this will be a useful addition to the existing test framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some minor improvements to DynamoDS#9667: please take a look. I wasn't able to reproduce your test case to fail after these changes.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@ColinDayOrg