fix: await app restore completion before restart #256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition where AppReloader.restartApp() was called immediately after launching async restore, causing customizations to not be restored. Now wraps restore in withContext(Dispatchers.IO) and restarts only after DB writes complete. Added error handling for restore failures.
fixes #255
Type of Change
All Submissions
Before Opening Pull Request
Description of Changes
Changes Description
Technical Details
The issue occurred when AppReloader.restartApp() was called immediately after launching the async restore process in MainActivity.kt. This led to a race condition where the app would restart before customizations were fully restored to the Room database.
The fix ensures:
This PR addresses the race condition identified in issue #255 and implements the solution suggested by contributor @0xtanmoysamanta.
Test Device: