tests: Do not retain values in StressTest #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StressTest required a lot of memory since it collected all `init` and `mutate` return values in a list. Instead, cross values off of a short list for "contains" type checks and use `hashCode()` to stand in for the actual value in statistical tests. Verified locally that the test now passes with `--jvmopt=-Xmx512M`.
ccfed6d to
7f6d143
Compare
This was referenced Oct 16, 2023
Merged
br-lewis
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StressTest required a lot of memory since it collected all
initandmutatereturn values in a list. Instead, cross values off a short list for "contains" type checks and usehashCode()to stand in for the actual value in statistical tests.Verified locally that the test now passes with
--jvmopt=-Xmx512M.