Skip to content

fix: handle null values in Arrays.equal/compare hooks #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonresch merged 1 commit into from
Nov 24, 2025
Merged

fix: handle null values in Arrays.equal/compare hooks #1017

simonresch merged 1 commit into from
Nov 24, 2025

Conversation

@simonresch
Copy link
Contributor

@simonresch simonresch commented Nov 20, 2025

null arrays would crash in the Arrays.equal and Arrays.compare hooks.

@simonresch
fix: handle null values in Arrays.equal/compare hooks
c1609a3 
`null` arrays would crash in the `Arrays.equal` and `Arrays.compare`
hooks.
@simonresch simonresch force-pushed the fix-segfault-on-null-array branch from 97c492d to c1609a3 Compare November 20, 2025 14:47
@simonresch simonresch marked this pull request as ready for review November 20, 2025 14:47
@simonresch simonresch requested a review from a team November 20, 2025 14:48
oetr
oetr approved these changes Nov 24, 2025
View reviewed changes
Copy link
Contributor

@oetr oetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simonresch simonresch merged commit 40f26a0 into main Nov 24, 2025
9 checks passed
@simonresch simonresch deleted the fix-segfault-on-null-array branch November 24, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oetr oetr oetr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simonresch @oetr