Skip to content

fix(pinia-orm): new doesnt fire creating or created hook#808

Merged
CodeDredd merged 3 commits intonext-releasefrom
pinia-orm-801
Jan 10, 2023
Merged

fix(pinia-orm): new doesnt fire creating or created hook#808
CodeDredd merged 3 commits intonext-releasefrom
pinia-orm-801

Conversation

@CodeDredd
Copy link
Copy Markdown
Owner

@CodeDredd CodeDredd commented Jan 6, 2023

🔗 Linked issue

closes #801

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd added the bug Something isn't working label Jan 6, 2023
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 99.67% // Head: 99.67% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cfad782) compared to base (85372c9).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head cfad782 differs from pull request most recent head 2f484c6. Consider uploading reports for the commit 2f484c6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          85       85           
  Lines        5552     5558    +6     
  Branches      486      488    +2     
=======================================
+ Hits         5534     5540    +6     
  Misses         17       17           
  Partials        1        1           
Impacted Files Coverage Δ
packages/pinia-orm/src/query/Query.ts 99.80% <100.00%> (+<0.01%) ⬆️
packages/pinia-orm/src/repository/Repository.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CodeDredd CodeDredd changed the base branch from master to next-release January 10, 2023 16:57
@CodeDredd CodeDredd merged commit 8e4e351 into next-release Jan 10, 2023
@CodeDredd CodeDredd deleted the pinia-orm-801 branch January 10, 2023 16:58
@CodeDredd CodeDredd mentioned this pull request Jan 10, 2023
CodeDredd added a commit that referenced this pull request Jan 24, 2023
* fix(pinia-orm): `new` doesnt fire creating or created hook (#808)

* fix(pinia-orm): `new` doesnt fire creating or created hook
closes #801

* refactor(pinia-orm): fix type

* refactor(pinia-orm): linting

* chore: Update sponsors

* perf(pinia-orm): Querying models with belongsToMany relation are extremely slow (#876)

closes #823

* feat(pinia-orm): Support of composite key for some relations (#885)

- `belongsTo`
- `hasOne`
- `hasMany`

closes #829

* chore: Update nuxt2comp example

* chore(normalizr): Add unpkg & jsdelivr support

* perf(pinia-orm): Improve caching for hydrated models (#889)

* perf(pinia-orm): Improve caching for hydrated models

* refactor(pinia-orm): add missing operations

* refactor(pinia-orm): removed json comparison

* refactor(pinia-orm): remove cached objects if deleted

closes #853

* chore(normalizr): upgrade eslint config packages

* chore: Set ci to node version 18

* chore: ignore playground for eslint

* chore: update linting for ci
@CodeDredd CodeDredd mentioned this pull request Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"new" doesnt fire creating or created hook

2 participants