fix(pinia-orm): null is casted in DateCast #565
Merged
CodeDredd merged 7 commits intoCodeDredd:masterfrom Nov 14, 2022
tklaas:master
Merged
fix(pinia-orm): null is casted in DateCast #565CodeDredd merged 7 commits intoCodeDredd:masterfrom tklaas:master
null is casted in DateCast #565CodeDredd merged 7 commits intoCodeDredd:masterfrom
tklaas:master
Conversation
Owner
|
Looks good. I don't know why i left null out. 🤔 . |
null for DateCast
null for DateCast null is casted in DateCast
CodeDredd
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#546
❓ Type of change
📚 Description
@CodeDredd
Is there a reason, that null values are not allowed for DateCast and instead being converted to a date
1970-01-01T00:00:00.000ZI used this for my own code and hat it implemented as CustomCast with null values but would like to replace my code now with the included DateCast.
📝 Checklist