Skip to content

fix(pinia-orm): delete on cascade doesn't work with n:m relations#562

Merged
CodeDredd merged 1 commit intomasterfrom
del-cascade-mn-relations
Nov 10, 2022
Merged

fix(pinia-orm): delete on cascade doesn't work with n:m relations#562
CodeDredd merged 1 commit intomasterfrom
del-cascade-mn-relations

Conversation

@CodeDredd
Copy link
Copy Markdown
Owner

@CodeDredd CodeDredd commented Nov 10, 2022 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The onDelete('cascade') method is not working wtih n:m relations (BelongsToMany).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd added the bug Something isn't working label Nov 10, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 10, 2022 •
edited
Loading

Codecov Report

Base: 99.73% // Head: 99.73% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ac886e1) compared to base (c95e897).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          83       83           
  Lines        5280     5286    +6     
  Branches      477      479    +2     
=======================================
+ Hits         5266     5272    +6     
  Misses         14       14
Impacted Files Coverage Δ
packages/pinia-orm/src/query/Query.ts 99.89% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CodeDredd CodeDredd merged commit 37b767c into master Nov 10, 2022
@CodeDredd CodeDredd deleted the del-cascade-mn-relations branch November 10, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CodeDredd @codecov-commenter