Skip to content

fix(docs): docs broken with nuxt3.0.0-rc.13#543

Merged
CodeDredd merged 3 commits intomasterfrom
docs-broken
Nov 8, 2022
Merged

fix(docs): docs broken with nuxt3.0.0-rc.13#543
CodeDredd merged 3 commits intomasterfrom
docs-broken

Conversation

@CodeDredd
Copy link
Copy Markdown
Owner

@CodeDredd CodeDredd commented Nov 8, 2022

🔗 Linked issue

closes #541

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

nuxt 3 RC 13 breaks the doc build

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 8, 2022 •
edited
Loading

Codecov Report

Base: 99.63% // Head: 99.63% // No change to project coverage 👍

Coverage data is based on head (18da40c) compared to base (1d8192c).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          81       81           
  Lines        5143     5143           
  Branches      461      461           
=======================================
  Hits         5124     5124           
  Misses         16       16           
  Partials        3        3

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CodeDredd CodeDredd merged commit 86d581a into master Nov 8, 2022
@CodeDredd CodeDredd deleted the docs-broken branch November 8, 2022 08:03
@CodeDredd CodeDredd mentioned this pull request Nov 8, 2022
Merged
@paolodina
Copy link
Copy Markdown
Contributor

paolodina commented Nov 8, 2022 •
edited
Loading

Hello @CodeDredd, still a little issue on the docs! Click on the link "how to use Pinia ORM", 404 not found.

If you mind to do the change, this

https://pinia-orm.codedredd.de/getting-started/usage

should be

https://pinia-orm.codedredd.de/guide/getting-started/usage

@paolodina
Copy link
Copy Markdown
Contributor

paolodina commented Nov 8, 2022

@CodeDredd
Sorry, I realized I'm not really in-topic with this PR. Anyway, I've spotted some other minor mistakes, if you are not in hurry I can submit a PR in a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The doc website is down

3 participants

@CodeDredd @codecov-commenter @paolodina