Skip to content

feat(pinia-orm): Enhance whereIn to support Set as values#537

Merged
CodeDredd merged 2 commits intonext-releasefrom
pinia-orm-524
Nov 7, 2022
Merged

feat(pinia-orm): Enhance whereIn to support Set as values#537
CodeDredd merged 2 commits intonext-releasefrom
pinia-orm-524

Conversation

@CodeDredd
Copy link
Copy Markdown
Owner

@CodeDredd CodeDredd commented Nov 7, 2022 •
edited
Loading

🔗 Linked issue

closes #524

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Makes it possible to use whereIn with Set

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd added the enhancement New feature or request label Nov 7, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 7, 2022

Codecov Report

Base: 99.63% // Head: 99.63% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7df47ca) compared to base (1d1581a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@              Coverage Diff              @@
##           next-release     #537   +/-   ##
=============================================
  Coverage         99.63%   99.63%           
=============================================
  Files                81       81           
  Lines              5143     5146    +3     
  Branches            461      462    +1     
=============================================
+ Hits               5124     5127    +3     
  Misses               16       16           
  Partials              3        3
Impacted Files Coverage Δ
packages/pinia-orm/src/query/Query.ts 99.67% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CodeDredd CodeDredd merged commit 05d51a5 into next-release Nov 7, 2022
@CodeDredd CodeDredd deleted the pinia-orm-524 branch November 7, 2022 14:01
@CodeDredd CodeDredd mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CodeDredd @codecov-commenter