fix(pinia-orm): pivot are not correctly loaded#438
Merged
CodeDredd merged 9 commits intoCodeDredd:masterfrom Oct 17, 2022
Merged
fix(pinia-orm): pivot are not correctly loaded#438CodeDredd merged 9 commits intoCodeDredd:masterfrom
CodeDredd merged 9 commits intoCodeDredd:masterfrom
Conversation
Owner
|
thx for the PR. The |
CodeDredd
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#423
❓ Type of change
📚 Description
Fixes errors in correct pivot element matching when querying for multiple records of an entity that has an m-n relationship to another entity.
Reason for bug is missing deep copy inside a loop. Used lodash because other methods may not duplicate all types appropriately (Date objects,...).
Documentation update: only added in Readme that normalizr needs to be build before running tests for pinia-orm (otherwise it fails with a pretty obscure error message)
📝 Checklist