fix(pinia-orm): Nuxt2 with composition api not working#228
Merged
CodeDredd merged 6 commits intonext-releasefrom Aug 20, 2022
Merged
fix(pinia-orm): Nuxt2 with composition api not working#228CodeDredd merged 6 commits intonext-releasefrom
CodeDredd merged 6 commits intonext-releasefrom
Conversation
# Conflicts: # packages/nuxt/package.json # packages/pinia-orm/package.json # pnpm-lock.yaml
- Nuxt 2 somehow doesnt run babel with `cjs` files and therefor features like "nullish coalescing operator" are not working. As a workaround the files are renamed to 'js' - Also fixed the new uid decorators not working correctly - Added an option to pass `pinia` to the store instance to be able to use it outside of `setup`
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
close #216
Context
Somehow nuxt 2 is not transpiling
cjsfiles correctly with babel. If the build files are renamed tojsthen everything works. Also no workaround or related topic worked to fix this behaviour on nuxt 2 side.Tried solutions: nuxt/nuxt#7722
For nuxt2 with composition api now the pinia store has to be passed to the
useRepofunction