The new check ensures that the value is an instance of Date in the serializeValue function of Model.ts.

Adding a condition like if ('toISOString' in value') to check for the existence of a method on an object can lead to issues in JavaScript because it does not accurately check whether the method actually exists and can be called. This is because objects in JavaScript can have inherited properties, and the in operator also checks for properties in the object's prototype chain. As a result, using the in operator to check for the existence of a method on an object can sometimes result in unexpected behaviour.

In my personal experience, I had a big headache with the in operator in Python, and since then, I have never used in in any language with similar behaviour. Because it affected performance much and resulted in unexpected outcomes.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/in#Caveats :

The in operator returns true if the specified property is in the specified object or its prototype chain.

A few examples:

const myObj = {
  toISOString: function () {
    return 'some value';
  }
};

// This will return true, even though myObj is not a Date object
console.log('toISOString' in myObj);

// This will return false because myObj is not a valid Date object
console.log(myObj instanceof Date && !isNaN(myObj.getTime()) && typeof myObj.toISOString === 'function');

class MyObject {
  toISOString() {
    return 'some value';
  }
}

class MyChildObject extends MyObject {
  
}

const myObj = new MyChildObject();

// This will return true, because myObj's prototype chain includes the toISOString method
console.log('toISOString' in myObj);

// This will return false because myObj is not a valid Date object
console.log(myObj instanceof Date && !isNaN(myObj.getTime()) && typeof myObj.toISOString === 'function');

🔗 Linked issue

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• [ x] 🐞 Bug fix (a non-breaking change that fixes an issue)
• [ x] 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The new check ensures that the value is an instance of Date, that its getTime() method returns a valid number, and that its toISOString() method returns a valid ISO 8601 string.

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.