Skip to content

Fix mctp-bench build on musl libc#125

Merged
jk-ozlabs merged 2 commits intoCodeConstruct:mainfrom
jk-ozlabs:pr/mctp-bench-prctl
Oct 27, 2025
Merged

Fix mctp-bench build on musl libc#125
jk-ozlabs merged 2 commits intoCodeConstruct:mainfrom
jk-ozlabs:pr/mctp-bench-prctl

Conversation

@jk-ozlabs
Copy link
Copy Markdown
Member

Remove the prctl.h includes, as they're unused. Do a bit of a header tidy at the same time.

Khem reports that including both linux/prctl.h and sys/prctl.h appears
to break builds with musl:

    In file included from ../sources/mctp-2.3/src/mctp-bench.c:16:
    ../recipe-sysroot/usr/include/sys/prctl.h:88:8: error: redefinition of 'prctl_mm_map'
       88 | struct prctl_mm_map {
          |        ^
    ../recipe-sysroot/usr/include/linux/prctl.h:134:8: note: previous definition is here
      134 | struct prctl_mm_map {
          |        ^

We're not using prctl() at present, so both can be removed.

Reported-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Add missing license header, and separate the pre-header define.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
@jk-ozlabs jk-ozlabs merged commit 76e31c4 into CodeConstruct:main Oct 27, 2025
3 checks passed
@jk-ozlabs jk-ozlabs deleted the pr/mctp-bench-prctl branch October 27, 2025 02:57
Copy link
Copy Markdown
Contributor

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants