add cancel all market orders option to cli. change host_ip #701
Merged
joelvai merged 3 commits intoCodaone:develfrom Mar 11, 2020
Merged
add cancel all market orders option to cli. change host_ip #701joelvai merged 3 commits intoCodaone:develfrom
joelvai merged 3 commits intoCodaone:develfrom
Conversation
Collaborator
thehapax
commented
Nov 21, 2019
- Added option to allow user to cancel all market orders for account on dexbot-cli .
- Todo: Option should be added to to dexbot-gui (for joelvai)
- Also corrected host_ip from 8.8.8.8 to 1.1.1.1, in cases where prior maybe blocked, latter better choice.
joelvai
approved these changes
Mar 11, 2020
Collaborator
joelvai
left a comment
There was a problem hiding this comment.
I changed the host_ip to 8.8.8.8 since 1.1.1.1 wasn't responding when testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.